Add nearing quota warning #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girishpanchal30
force-pushed
the
feat/opml-service/1318
branch
from
f09d200 to
00c46dc
Compare
abaicus
requested changes
Mar 20, 2025
|
@girishpanchal30 looks good 👍🏻 Can you please also fix the merge conflict on this? Thank you! |
|
@abaicus Resolved |
|
@abaicus I applied the following changes to index 4ad23a7..3375b31 100644
--- a/tests/test-preloading.php
+++ b/tests/test-preloading.php
@@ -52,7 +52,12 @@ class Test_Preloading extends WP_UnitTestCase {
set_theme_mod( 'header_image', $header_image_data->url );
set_theme_mod( 'header_image_data', $header_image_data );
- $header = get_header_image_tag();
+ $header = get_header_image_tag(
+ array(
+ 'fetchpriority' => 'high',
+ )
+ );
+
$this->assertStringContainsString( 'fetchpriority="high"', $header );
// Test it doesn't add the attribute when called again.
@@ -62,11 +67,18 @@ class Test_Preloading extends WP_UnitTestCase {
public function test_preloading_logo() {
set_theme_mod( 'custom_logo', self::$sample_attachement );
+ add_filter( 'get_custom_logo_image_attributes', array( $this, 'custom_logo_image_attributes' ), 999 );
$logo = get_custom_logo();
+ remove_filter( 'get_custom_logo_image_attributes', array( $this, 'custom_logo_image_attributes' ), 999 );
$this->assertStringContainsString( 'fetchpriority="high"', $logo );
// Test it doesn't add the attribute when called again.
$logo = get_custom_logo();
$this->assertStringNotContainsString( 'fetchpriority="high"', $logo );
}
+
+ public function custom_logo_image_attributes( $attributes ) {
+ $attributes['fetchpriority'] = 'high';
+ return $attributes;
+ }
}
Should I include these changes in this PR? |
6 tasks
|
@girishpanchal30 please rebase to have the tests fixed |
girishpanchal30
force-pushed
the
feat/opml-service/1318
branch
from
9f628a2 to
6a790ed
Compare
|
@selul Done! |
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Show a warning for exceeding quota soon if the user reaches over 50% of their monthly visit limit within two weeks.
Closes https://github.com/Codeinwp/optimole-service/issues/1318
How to test the changes in this Pull Request:
days_since_registrationvalue.Other information: